Skip to content

add spirv-unknown-wgsl target via naga #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

add spirv-unknown-wgsl target via naga #280

wants to merge 14 commits into from
+1,063 −596

Conversation

Firestar99
Copy link
Member

@Firestar99 Firestar99 commented Jun 11, 2025 •
edited
Loading

Requires #271

This was referenced Jun 11, 2025
Closed
Closed
@Firestar99 Firestar99 force-pushed the naga branch 4 times, most recently from 016845f to 6696b4f Compare June 13, 2025 08:48
@Firestar99 Firestar99 changed the title add wgsl-unknown-unknown target via naga add spirv-unknown-wgsl target via naga Jun 13, 2025
@Firestar99 Firestar99 force-pushed the naga branch 9 times, most recently from ca183f5 to 7ff21a6 Compare June 16, 2025 09:49
@LegNeato
Copy link
Collaborator

LegNeato commented Jun 22, 2025 •
edited
Loading

I think this is fine and later when we change it to have something generic like "gpu" we can document it / support the old style as well. Do you think instead it should be spirv-[unknown-]naga-wgsl or spirv-[unknown-]wgpu-wgsl? Probably not but wanted to check in case you hadn't thought of those options and they are more appropriate. I doubt we'd have another or "pure" wgsl backend for a long time.

@Firestar99
Copy link
Member Author

I actually think we should add naga to the target, since we could be having a *-naga-glsl and a *-cross-glsl target via spirv-cross

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyb eddyb Awaiting requested review from eddyb eddyb will be requested when the pull request is marked ready for review eddyb is a code owner

@LegNeato LegNeato Awaiting requested review from LegNeato LegNeato will be requested when the pull request is marked ready for review LegNeato is a code owner

@schell schell Awaiting requested review from schell schell will be requested when the pull request is marked ready for review schell is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Firestar99 @LegNeato